fix(jit): input arguments required error #2756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
karatakis
changed the title
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
|
PR closed after 10 days of inactivity. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
+ Coverage 87.25% 87.30% +0.05%
==========================================
Files 254 254
Lines 25219 25311 +92
==========================================
+ Hits 22006 22099 +93
+ Misses 3213 3212 -1 ☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
state: inactive
karatakis
changed the title
meskill
reviewed
Sep 16, 2024
meskill
approved these changes
Sep 18, 2024
Co-authored-by: Kiryl Mialeshka <[email protected]>
Co-authored-by: Kiryl Mialeshka <[email protected]>
meskill
approved these changes
Sep 19, 2024
meskill
approved these changes
Sep 19, 2024
meskill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR will enable Tailcall JIT implementation to validate the Input arguments if their fields meet the schema requirements. When an argument does not meet the requirements, an error is thrown.
Fixes:
Build & Testing:
cargo testsuccessfully../lint.sh --mode=fixto fix all linting issues raised by./lint.sh --mode=check.Checklist:
<type>(<optional scope>): <title>